Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce icons.json based icon translations #211

Closed
kongo09 opened this issue Nov 26, 2024 · 4 comments · Fixed by #216
Closed

Introduce icons.json based icon translations #211

kongo09 opened this issue Nov 26, 2024 · 4 comments · Fixed by #216
Assignees
Labels
enhancement New feature or request

Comments

@kongo09
Copy link
Owner

kongo09 commented Nov 26, 2024

The use of the icon attribute for entities seems to be phased out and instead a new approach with icon translations is used:
https://developers.home-assistant.io/blog/2024/01/19/icon-translations/

There is already a pending pull request. #142

It has also come up in this issue: #198

@merquel
Copy link

merquel commented Nov 28, 2024

Gave some input regarding the humidifier entity on this in #198 (comment)

@kongo09 kongo09 self-assigned this Nov 30, 2024
@kongo09
Copy link
Owner Author

kongo09 commented Dec 1, 2024

I've done a beta with full icon translations (and more): please give it a spin at v0.30.0-beta.1

@merquel
Copy link

merquel commented Dec 2, 2024

Tried to install v0.30.0-beta.2 but wasn't able to load the integration.

2024-12-02 03:06:16.069 ERROR (MainThread) [homeassistant.bootstrap] Error setting up integration philips_airpurifier_coap - received exception Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/setup.py", line 185, in async_setup_component await future File "/usr/src/homeassistant/homeassistant/setup.py", line 185, in async_setup_component await future File "/usr/src/homeassistant/homeassistant/setup.py", line 165, in async_setup_component result = await _async_setup_component(hass, domain, config) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/setup.py", line 343, in _async_setup_component processed_config = conf_util.async_drop_config_annotations( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/config.py", line 908, in async_drop_config_annotations if integration.domain in config and integration.domain != HOMEASSISTANT_DOMAIN: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: argument of type 'function' is not iterable

@kongo09
Copy link
Owner Author

kongo09 commented Dec 2, 2024

I must have messed something up. Will check later in the week. Probably the SCHEMA.

@kongo09 kongo09 linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants