Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the keycloak theme to match the current keycloak version #166

Open
sjd78 opened this issue Feb 16, 2024 · 2 comments
Open

Update the keycloak theme to match the current keycloak version #166

sjd78 opened this issue Feb 16, 2024 · 2 comments
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@sjd78
Copy link
Member

sjd78 commented Feb 16, 2024

Summary

The keyclock theme in the https://github.com/konveyor/tackle-keycloak-theme repo should be updated to match the currently used version of keycloak. The theme seems to be referencing keycloak 12, while the operator is using keycloak 18.

Related to #113

Why

In most configurations of the operator, the container quay.io/konveyor/tackle-keycloak-init is used to initialize the keycloak container with a custom konveyor branding/theme. The tackle-keycloak-init container is generated from the repo https://github.com/konveyor/tackle-keycloak-theme. The further the keycloak theme drifts apart from the keycloak container, the higher the risk that the theme breaks keycloak functionality.

Considerations

The keycloak theme is only applied to the default upstream build. Any configurations or downstream builds of the operator that end up using RHSSO will not attempt to apply any themes.

References

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 16, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 16, 2024
@sjd78
Copy link
Member Author

sjd78 commented Feb 16, 2024

cc: @ibolton336 , @dymurray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant