Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Support reused connection for better performance. #753

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Oct 8, 2024

Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
@aufi
Copy link
Member

aufi commented Oct 10, 2024

There was an interesting error on CI (Konveyor installation without this PR changes, most likely an infra problem, not blocking this PR merge)

time=2024-10-09T23:00:43Z level=info msg=[binding] |200|  GET /hub/tasks/3
time=2024-10-09T23:00:48Z level=info msg=[binding] |500|  GET /hub/tasks/3
time=2024-10-09T23:00:48Z level=info msg=[binding] |500|  GET /hub/tasks
    analysis_test.go:148: unable to get all the tasks, err: GET /hub/tasks failed: 500(Internal Server Error) body: {"error":"database is locked"}
=== RUN   TestApplicationAnalysis/Tackle_Testapp_public_with_package_filter
time=2024-10-09T23:00:49Z level=info msg=[binding] |500|  POST /hub/applications
    error.go:11: POST /hub/applications failed: 500(Internal Server Error) body: {"error":"database is locked"}
time=2024-10-09T23:00:49Z level=info msg=[binding] |400|  POST /hub/tasks
    error.go:11: POST /hub/tasks failed: 400(Bad Request) body: {"error":"Key: 'Task.Application.ID' Error:Field validation for 'ID' failed on the 'required' tag"}
time=2024-10-09T23:00:49Z level=info msg=[binding] |500|  PUT /hub/tasks/0
    error.go:11: PUT /hub/tasks/0 failed: 500(Internal Server Error) body: {"error":"database is locked"}
time=2024-10-09T23:00:49Z level=info msg=[binding] |500|  GET /hub/tasks/0
time=2024-10-09T23:00:49Z level=info msg=[binding] |500|  GET /hub/tasks
    analysis_test.go:148: unable to get all the tasks, err: GET /hub/tasks failed: 500(Internal Server Error) body: {"error":"database is locked"}
=== RUN   TestApplicationAnalysis/Customer_Tomcat_Legacy_-_shoud_never_fail
time=2024-10-09T23:00:49Z level=info msg=[binding] |500|  POST /hub/applications
    error.go:11: POST /hub/applications failed: 500(Internal Server Error) body: {"error":"database is locked"}
time=2024-10-09T23:00:49Z level=info msg=[binding] |400|  POST /hub/tasks
    error.go:11: POST /hub/tasks failed: 400(Bad Request) body: {"error":"Key: 'Task.Application.ID' Error:Field validation for 'ID' failed on the 'required' tag"}
time=2024-10-09T23:00:49Z level=info msg=[binding] |404|  PUT /hub/tasks/0
    error.go:11: PUT /hub/tasks/0 failed: 404(Not Found) body: {"error":"record not found"}
time=2024-10-09T23:00:49Z level=info msg=[binding] |404|  GET /hub/tasks/0
time=2024-10-09T23:00:49Z level=info msg=[binding] |200|  GET /hub/tasks
    analysis_test.go:164: Analyze Task failed. Details:
[]api.Task{
...
      },
      api.TaskEvent{
        Kind:   "PodCreated",
        Count:  1,
        Reason: "konveyor-tackle/task-2-gpf6x",
        Last:   2024-10-09 23:00:12 UTC,
      },
      api.TaskEvent{
        Kind:   "PodPending",
        Count:  21,
        Reason: "0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod.",
        Last:   2024-10-09 23:00:47 UTC,
      },
    },
...

Full output: https://github.com/konveyor/analyzer-lsp/actions/runs/11264134803/attempts/1?pr=703

@jortel Would you mind look if it might be related to similar problem as this PR should solve? (not meaning the insufficient cpu, but possible backend failure on not enough resources)

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel merged commit 72fd8df into konveyor:main Oct 10, 2024
13 checks passed
dymurray pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants