Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing koreader logos to gallery on the official website #26

Open
FajnB opened this issue Nov 13, 2023 · 4 comments · Fixed by #27
Open

Add missing koreader logos to gallery on the official website #26

FajnB opened this issue Nov 13, 2023 · 4 comments · Fixed by #27

Comments

@FajnB
Copy link

FajnB commented Nov 13, 2023

  • KOReader version: From 2022.6
  • Device: Official koreader website

Issue

The latest koreader logo in the gallery is (2022.05 "Tulip")
This means that there is 12 logos missing

Steps to reproduce

Go to official koreader website
Go to Gallery
Scroll to the bottom
Observe the missing logos

Suggested solution

Add the missing logos of these releases:

@Frenzie Frenzie transferred this issue from koreader/koreader Nov 13, 2023
@Frenzie
Copy link
Member

Frenzie commented Nov 13, 2023

I thought I'd updated it a little more recently than that. I hope you didn't spend too much time manually listing them all; I think the point was clear regardless. ^_^

@FajnB
Copy link
Author

FajnB commented Nov 13, 2023

I just wanted to make it easier for you to find the logos so I linked the releases. 😉

Frenzie added a commit to Frenzie/koreader.github.io that referenced this issue Nov 13, 2023
Frenzie added a commit that referenced this issue Nov 13, 2023
@Frenzie
Copy link
Member

Frenzie commented Nov 13, 2023

Back when I created it in the first place I wrote a quick script to generate and help update it. :-)

https://github.com/koreader/koreader.github.io/blob/b9567f05d2596145b525f9ed9dde0fb4fd680426/generate-gallery.py

@Frenzie
Copy link
Member

Frenzie commented Nov 13, 2023

Ah, but GH changed something about how their image uploads work. The image link now looks like https://github.com/koreader/koreader/assets/202757/a64eb64f-504a-44b3-9317-4aa50aa5ade8 despite being a PNG image and that breaks the script. That's a bit annoying.

@Frenzie Frenzie reopened this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants