-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: set scale_weights
in CLI
#121
Comments
These hyperparameters are dependent on viewing conditions indeed. They've been tuned (or overfitted 😄) for the TID2013 dataset. It would be nice to have something for 2x images. Perhaps just shifting them by one would be okay? But without a dataset to validate this, it'd be only guessing. I'd rather not expose that in CLI as raw numbers, because if I don't have a way to set better values, I don't expect users to be able to either. |
Hmm, this will mean that the best 2x image is a good quality 1x image scale up bicubically :-) To be honest, I'm surprised that the first layer is 7 times less significant than second. This is the first thing I'd like to experiment with if this functionality will be available. |
You can experiment with it by recompiling the program. Compiling Rust is a bit slow, but not difficult. |
Agree. I've experimented with only 2 scales ( |
How did you verify "reasonable"? The weights affect the TID benchmark by about 3%, so it's not something you can eyeball. |
I'm sure you've already seen this thread, but I'd like to add it here for others who will read the issue.
|
In my understanding this is a key parameter which should not be hardcoded, since it mostly depends on how the image is showed to the user. At least I believe
scale_weights
should be different for 2x and 1x images.The possible syntax:
As a bonus, this unleashes the easy way to turn multiple-resolution comparison to single-resolution just by defining
--weights 1
.By the way I'm wondering how the current
DEFAULT_WEIGHTS
was chosen. There is a comment in the code: "inspired by the IW-SSIM, but details of the algorithm and weights are different" but without details.The text was updated successfully, but these errors were encountered: