Add description flag to custom attestation creation command

Author: jumboduck

cmd/kosli/createAttestationType.go

@@ -20,7 +20,8 @@ type createAttestationTypeOptions struct {
 }
 
 type CreateAttestationTypePayload struct {
-	TypeName string `json:"type_name"`
+	TypeName    string `json:"name"`
+	Description string `json:"description"`
 }
 
 func newCreateAttestationTypeCmd(out io.Writer) *cobra.Command {
@@ -43,7 +44,7 @@ func newCreateAttestationTypeCmd(out io.Writer) *cobra.Command {
 		},
 	}
 
-	//cmd.Flags().StringVarP(&o.payload.Description, "description", "d", "", envDescriptionFlag)
+	cmd.Flags().StringVarP(&o.payload.Description, "description", "d", "", attestationTypeDescriptionFlag)
 
 	addDryRunFlag(cmd)
 	return cmd
@@ -59,15 +60,15 @@ func (o *createAttestationTypeOptions) run(args []string) error {
 	}
 
 	reqParams := &requests.RequestParams{
-		Method:  http.MethodPost,
-		URL:     url,
+		Method: http.MethodPost,
+		URL:    url,
 		Form:   form,
-		DryRun:  global.DryRun,
-		Token:   global.ApiToken,
+		DryRun: global.DryRun,
+		Token:  global.ApiToken,
 	}
 	_, err = kosliClient.Do(reqParams)
 	if err == nil && !global.DryRun {
-		logger.Info("foo bar fix me %s", o.payload.TypeName)
+		logger.Info("attestation-type %s was created", o.payload.TypeName)
 	}
 	return err
 }

cmd/kosli/createAttestationType_test.go

@@ -28,14 +28,19 @@ func (suite *CreateAttestationTypeTestSuite) TestCustomAttestationTypeCmd() {
 	tests := []cmdTestCase{
 		{
 			wantError: true,
-			name:      "fails when more arguments are provided",
+			name:      "fails when no arguments are provided",
 			cmd:       "create attestation-type" + suite.defaultKosliArguments,
 			golden:    "Error: accepts 1 arg(s), received 0\n",
 		},
 		{
-			name:      "type name is provided",
-			cmd:       "create attestation-type wibble" + suite.defaultKosliArguments,
-			golden:    "attestation-type wibble was created\n",
+			name:   "type name is provided",
+			cmd:    "create attestation-type wibble" + suite.defaultKosliArguments,
+			golden: "attestation-type wibble was created\n",
+		},
+		{
+			name:   "type description is provided",
+			cmd:    "create attestation-type wibble-2 -d 'description of attestation type'" + suite.defaultKosliArguments,
+			golden: "attestation-type wibble-2 was created\n",
 		},
 	}
 

cmd/kosli/root.go

@@ -237,6 +237,7 @@ The ^.kosli_ignore^ will be treated as part of the artifact like any other file,
 	sonarRevisionFlag                    = "[conditional] The revision of the SonarCloud/SonarQube project. Only required if you want to use the project key/revision to get the scan results rather than using Sonar's metadata file and you have overridden the default revision, or you aren't using a CI. Defaults to the value of the git commit flag."
 	logicalEnvFlag                       = "[required] The logical environment."
 	physicalEnvFlag                      = "[required] The physical environment."
+	attestationTypeDescriptionFlag       = "[optional] The attestation type description."
 )
 
 var global *GlobalOpts