Skip to content

Commit

Permalink
Delete dead comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jumboduck committed Nov 27, 2023
1 parent f52e85e commit a495036
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions cmd/kosli/reportApproval_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (suite *ApprovalReportTestSuite) TestApprovalReportCmd() {
},
{
wantError: true,
name: "report approval with no environment name or oldest commit fails",
name: "report approval with no environment name and no oldest commit fails",
cmd: `report approval --fingerprint ` + suite.artifactFingerprint + ` --flow ` + suite.flowName + ` --repo-root ../.. ` +
suite.defaultKosliArguments,
golden: "Error: at least one of --environment, --oldest-commit is required\n",
Expand All @@ -83,19 +83,13 @@ func (suite *ApprovalReportTestSuite) TestApprovalReportCmd() {
createSnapshot: true,
},
},

// Here is a case we need to investigate how to test:
// - Create approval with '--newest-commit HEAD~5', '--oldest-commit HEAD~7' and '--environment staging',
// then create approval only with '--environment staging',
// the resulting payload should contain a commit list of 4 commits, and an oldest_commit of HEAD~5
}
for _, t := range tests {
if t.additionalConfig != nil && t.additionalConfig.(reportApprovalTestConfig).createSnapshot {
ReportServerArtifactToEnv([]string{suite.artifactPath}, suite.envName, suite.T())
}
runTestCmd(suite.T(), []cmdTestCase{t})
}
// runTestCmd(suite.T(), tests)
}

func TestApprovalReportCommandTestSuite(t *testing.T) {
Expand Down

0 comments on commit a495036

Please sign in to comment.