bug: setting position to an arbitrary value just opens/closes it completely

[knoopx]

hi, just found your fork which solves the input delay I was having with the original implementation but it does not seem to properly handle arbitrary position values. is that expected?

[lbossle]

Hey, I encounter the same problem. But only sometimes. I think it has something to do with this

home-assistant-custom-components-cover-time-based-synced/custom_components/cover_time_based_synced/cover.py

Lines 317 to 333 in 7098bac

	def start_auto_updater(self):
	"""Start the autoupdater to update HASS while cover is moving."""
	_LOGGER.debug(self._name + ': ' + 'start_auto_updater')
	if self._unsubscribe_auto_updater is None:
	_LOGGER.debug(self._name + ': ' + 'init _unsubscribe_auto_updater')
	interval = timedelta(seconds=0.1)
	self._unsubscribe_auto_updater = async_track_time_interval(
	self.hass, self.auto_updater_hook, interval)
	@callback
	def auto_updater_hook(self, now):
	"""Call for the autoupdater."""
	self.async_schedule_update_ha_state()
	if self.position_reached():
	_LOGGER.debug(self._name + ': ' + 'auto_updater_hook :: position_reached')
	self.stop_auto_updater()
	self.hass.async_create_task(self.auto_stop_if_necessary())

home-assistant-custom-components-cover-time-based-synced/custom_components/cover_time_based_synced/travelcalculator.py

Lines 97 to 99 in 7098bac

	def position_reached(self):
	"""Return if cover has reached designated position."""
	return self.current_position() == self.travel_to_position

I think the issue is that when you are unlucky position_reached() is sometimes called too late due to the interval (so the condition is never met) and thus the cover just keeps on going.

Possible solutions:

1. Decrease increment -> Only less probable occurance
2. Use >= and <= in the comparison depending on the travel direction of the cover

I will try to fix this using the second option and create a pull request.