Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown middleware assumes a single server. #224

Open
totherik opened this issue Jun 6, 2014 · 2 comments
Open

shutdown middleware assumes a single server. #224

totherik opened this issue Jun 6, 2014 · 2 comments

Comments

@totherik
Copy link
Contributor

totherik commented Jun 6, 2014

If a client started both http and https servers on the same kraken app, shutdown middleware would only attempt to stop one server.

@aredridel
Copy link
Contributor

I wonder if there's a way to solve this. 1:N app:server is tough for this kind of thing, since the app doesn't really know about the servers that will call it.

@dougwilson
Copy link

Potentially server can be changed to an array and you can just accumulate the list of servers you have seen so far at

server = req.socket.server;
instead of only saving the server from the first request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants