Restore #[SensitiveParameter] attributes

Co-Authored-By: Alexander Kravchenko <[email protected]>

Author: jeromegamez

.php-cs-fixer.dist.php

@@ -16,8 +16,12 @@
         'concat_space' => [
             'spacing' => 'none',
         ],
+        'fully_qualified_strict_types' => [
+            'import_symbols' => true,
+            'leading_backslash_in_global_namespace' => true,
+        ],
         'method_argument_space' => [
-            'attribute_placement' => 'same_line',
+            'attribute_placement' => 'standalone', // same_line can break PHP <8.2
         ],
         'no_unused_imports' => true,
         'ordered_imports' => [

CHANGELOG.md

@@ -7,6 +7,11 @@ Please read about the future of the Firebase Admin PHP SDK on the
 
 ## [Unreleased]
 
+## Added
+
+* Re-added the `#[SensitiveParameter]` attribute because, while it's not supported in PHP 8.1, it can still be used
+  if placed in a standalone line above the variable or property.
+
 ## [7.21.1] - 2025-07-24
 
 ### Fixed

rector.php

@@ -19,5 +19,5 @@
         earlyReturn: true,
         phpunitCodeQuality: true,
     )
-    ->withImportNames(removeUnusedImports: true)
+    ->withImportNames(importShortClasses: false, removeUnusedImports: true)
 ;

src/Firebase/AppCheck/AppCheckTokenGenerator.php

@@ -11,8 +11,6 @@
 
 /**
  * @internal
- *
- * @todo Add #[SensitiveParameter] attribute to the private key once the minimum required PHP version is >=8.2
  */
 final class AppCheckTokenGenerator
 {
@@ -26,6 +24,7 @@ final class AppCheckTokenGenerator
      */
     public function __construct(
         private readonly string $clientEmail,
+        #[\SensitiveParameter]
         private readonly string $privateKey,
         ?ClockInterface $clock = null,
     ) {

src/Firebase/ServiceAccount.php

@@ -6,35 +6,44 @@
 
 /**
  * @internal
- *
- * @todo Add #[SensitiveParameter] attributes once the minimum required PHP version is >=8.2
  */
 final class ServiceAccount
 {
     public function __construct(
         /** @var non-empty-string */
         public string $type,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $projectId,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $clientEmail,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $clientId,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $privateKey,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $privateKeyId,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $authUri,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $tokenUri,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $authProviderX509CertUrl,
         /** @var non-empty-string */
+        #[\SensitiveParameter]
         public string $clientX509CertUrl,
         /** @var non-empty-string|null */
+        #[\SensitiveParameter]
         public ?string $quotaProjectId = null,
         /** @var non-empty-string|null */
+        #[\SensitiveParameter]
         public ?string $universeDomain = null,
     ) {
     }