Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit a825dfb

Browse files
committed
release 1.3.2
1 parent 0bdfd01 commit a825dfb

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

README.md

+12-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
* With Git: `git clone https://github.com/kriskbx/whatsapp-sharing.git`
1313
* Manually: [https://github.com/kriskbx/whatsapp-sharing/releases](https://github.com/kriskbx/whatsapp-sharing/releases)
1414

15-
Or include the hosted version on [jsdelivr](http://www.jsdelivr.com/): `//cdn.jsdelivr.net/whatsapp-sharing/1.3.1/whatsapp-button.js`
15+
Or include the hosted version on [jsdelivr](http://www.jsdelivr.com/): `//cdn.jsdelivr.net/whatsapp-sharing/1.3.2/whatsapp-button.js`
1616

1717
### 2. Integrate the buttons source
1818

@@ -34,18 +34,26 @@ If you want to customize the size, style, url or the sharing text, feel free to
3434

3535
Run `WASHAREBTN.crBtn();` after you loaded your content.
3636

37-
### 2. I want to track clicks on the button
37+
### 2. I want to track clicks on the button.
3838

3939
You can simply use JavaScript event handlers like `onClick` in the code of step 3.
4040

4141
### 3. Can I share photos/videos?
4242

4343
Nope, that's not possible (at the moment).
4444

45-
### 4. If WhatsApp is not installed on the device there's an error message
45+
### 4. If WhatsApp is not installed on the device there's an error message.
4646

47-
It's not possible to check if WhatsApp is installed on the device. This is a good thing, imagine a webpage can access the list of installed applications.
47+
It's not possible to check if WhatsApp is installed on the device. This is a good thing, imagine a webpage can access the list of installed applications. And for the record: why should someone try to share something via WhatsApp if he or she is not using WhatsApp at all?
4848

49+
### 5. I get "Sharing failed" all the time.
50+
51+
The main reason for this error are modifications of the original button code that prevent the library from selecting the buttons. As a result text and url won't be added and the url-scheme that stays empty. Repeat the installation steps and don't change the code on your own.
52+
You can test that by switching your Browsers useragent to "Android" or "iPhone" and running `WASHAREBTN.buttons` in your JavaScript console after that. This should list all the selected buttons on the page.
53+
54+
### 6. But I want my own styling and icons.
55+
56+
Well, this library was not made to be heavily modified. It was made to provide an easy way for non-devs to insert a button like this into their websites. If you want your own styling feel free to fork the repo, research the code and build your own button upon it. After all it's only a useragent check and an url-scheme.
4957

5058
## License
5159

bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "whatsapp-sharing",
3-
"version": "1.3.1",
3+
"version": "1.3.2",
44
"homepage": "https://github.com/kriskbx/whatsapp-sharing",
55
"authors": [
66
"kriskbx"

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "whatsapp-sharing",
3-
"version": "1.3.1",
3+
"version": "1.3.2",
44
"description": "WhatsApp Sharing Button",
55
"main": "-",
66
"scripts": {

0 commit comments

Comments
 (0)