Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking #16

Open
kristoferbaxter opened this issue Jul 24, 2017 · 5 comments
Open

Tracking #16

kristoferbaxter opened this issue Jul 24, 2017 · 5 comments
Assignees
@kristoferbaxter

Comments

@kristoferbaxter
Copy link
Owner

https://github.com/lukeed/ganalytics/blob/master/src/index.js

  1. Modify to use per-browser builds
  2. Use Object.assign since it's polyfilled for fallbacks.
@lukeed lukeed mentioned this issue Jul 24, 2017
Closed
@lukeed
Copy link
Collaborator

lukeed commented Jul 26, 2017

The library now ships with Object.assign 👍

@kristoferbaxter
Copy link
Owner Author

Nice! Will try to take a look this week.

@kristoferbaxter kristoferbaxter self-assigned this Sep 7, 2017
@kristoferbaxter
Copy link
Owner Author

Work ongoing: https://github.com/kristoferbaxter/preact-hn/tree/typescript

@lukeed
Copy link
Collaborator

lukeed commented Sep 7, 2017

Was a lack of something keeping you from using it directly?

@kristoferbaxter
Copy link
Owner Author

https://github.com/kristoferbaxter/preact-hn/blob/typescript/src/core/analytics.ts

Three items –

  1. Wanted to add some type safety
  2. Use Browser based builds to check DNT per platform
  3. Leverage URL/URLSearchParams directly (since they're polyfilled for devices without support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristoferbaxter kristoferbaxter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristoferbaxter @lukeed