Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

A question regarding the variable ray_directions #27

Open
OshriHalimi opened this issue Feb 6, 2021 · 1 comment
Open

A question regarding the variable ray_directions #27

OshriHalimi opened this issue Feb 6, 2021 · 1 comment

Comments

@OshriHalimi
Copy link

Based on the documentation here:

direction of each ray (a unit vector). `ray_directions[i][j]` denotes the direction of the ray

I would expect ray_directions to contain unit vectors. However, numerically looking into the values, this is not the case - the values are close to 1 but have a large variation around the exact value (around 10%-20%).

Is this a bug?
If not, what is the meaning of the vector magnitude?

Thanks!

@airalcorn2
Copy link

ray_directions is eventually normalized in run_one_iter_of_nerf.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants