Disable failing integration tests (knative#4300)

* Disable integration tests because they break a lot, per julz

* Actually run go and notice extra unused imports

* Revert "Disable integration tests because they break a lot, per julz"

I took out too much.

This reverts commit eca3a2d.

* Re-add simplifed sampleapp used by the consistency checker

* Forgot to autoformat after beating things with emacs and grep

* Add empty e2e tests

* Fix formatting again. `vi` this time

Author: Evan Anderson

test/e2e/main.go

@@ -14,4 +14,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package e2etest
+// Temporarily have an empty package here until we remove the prow jobs
+// https://github.com/knative/test-infra/pull/2891
+package e2e

test/e2e/sampleapp_test.go

@@ -18,8 +18,6 @@ package test
 
 import (
 	"flag"
-	"fmt"
-	"os"
 	"strings"
 )
 
@@ -29,40 +27,16 @@ var Flags = initializeFlags()
 
 // EnvironmentFlags define the flags that are needed to run the e2e tests.
 type EnvironmentFlags struct {
-	Cluster     string // K8s cluster (defaults to cluster in kubeconfig)
-	LogVerbose  bool   // Enable verbose logging
-	DockerRepo  string // Docker repo (defaults to $KO_DOCKER_REPO)
-	EmitMetrics bool   // Emit metrics
-	Tag         string // Docker image tag
-	Languages   string // Allowed languages to run
+	Languages string // Allowed languages to run
 }
 
 func initializeFlags() *EnvironmentFlags {
 	var f EnvironmentFlags
-	flag.StringVar(&f.Cluster, "cluster", "",
-		"Provide the cluster to test against. Defaults to the current cluster in kubeconfig.")
-
-	flag.BoolVar(&f.LogVerbose, "logverbose", false,
-		"Set this flag to true if you would like to see verbose logging.")
-
-	flag.BoolVar(&f.EmitMetrics, "emitmetrics", false,
-		"Set this flag to true if you would like tests to emit metrics, e.g. latency of resources being realized in the system.")
-
-	flag.StringVar(&f.DockerRepo, "dockerrepo", os.Getenv("KO_DOCKER_REPO"),
-		"Provide the uri of the docker repo you have uploaded the test image to using `uploadtestimage.sh`. Defaults to $KO_DOCKER_REPO")
-
-	flag.StringVar(&f.Tag, "tag", "latest", "Provide the version tag for the test images.")
-
 	flag.StringVar(&f.Languages, "languages", "", "Comma separated languages to run e2e test on.")
 
 	return &f
 }
 
-// ImagePath is a helper function to prefix image name with repo and suffix with tag
-func ImagePath(name string) string {
-	return fmt.Sprintf("%s/%s:%s", Flags.DockerRepo, name, Flags.Tag)
-}
-
 // GetAllowedLanguages is a helper function to return a map of allowed languages based on Languages filter
 func GetAllowedLanguages() map[string]bool {
 	allowed := make(map[string]bool)

test/e2e/sampleapptestbase.go

@@ -19,19 +19,13 @@ package sampleapp
 import (
 	"fmt"
 	"io/ioutil"
-	"os/exec"
-	"strings"
-	"testing"
 
 	yaml "gopkg.in/yaml.v2"
 )
 
 const (
 	// using these defaults if not provided, see useDefaultIfNotProvided function below
-	defaultSrcDir               = "../../docs/serving/samples/hello-world/helloworld-%s"
-	defaultWorkDir              = "helloworld-%s_tmp"
-	defaultAppName              = "helloworld-%s"
-	defaultYamlImagePlaceHolder = "docker.io/{username}/helloworld-%s"
+	defaultSrcDir = "../../docs/serving/samples/hello-world/helloworld-%s"
 
 	// ActionMsg serves as documentation purpose, which will be referenced for
 	// clearly displaying error messages.
@@ -51,45 +45,16 @@ type AllConfigs struct {
 
 // LanguageConfig contains all information for building/deploying an app
 type LanguageConfig struct {
-	Language             string    `yaml:"language"`
-	ExpectedOutput       string    `yaml:"expectedOutput"`
-	SrcDir               string    `yaml:"srcDir"`  // Directory contains sample code
-	WorkDir              string    `yaml:"workDir"` // Temp work directory
-	AppName              string    `yaml:"appName"`
-	YamlImagePlaceholder string    `yaml:"yamlImagePlaceholder"` // Token to be replaced by real docker image URI
-	PreCommands          []Command `yaml:"preCommands"`          // Commands to be ran before copying
-	Copies               []string  `yaml:"copies"`               // Files to be copied from SrcDir to WorkDir
-	PostCommands         []Command `yaml:"postCommands"`         // Commands to be ran after copying
+	Language string   `yaml:"language"`
+	SrcDir   string   `yaml:"srcDir"` // Directory contains sample code
+	Copies   []string `yaml:"copies"` // Files to be copied by the user from SrcDir
 }
 
-// Command contains shell commands
-type Command struct {
-	Exec string `yaml:"exec"`
-	Args string `yaml:"args"`
-}
-
-// UseDefaultIfNotProvided sets default value to SrcDir, WorkDir, AppName, and YamlImagePlaceholder if not provided
+// UseDefaultIfNotProvided sets default value of SrcDir if not provided
 func (lc *LanguageConfig) UseDefaultIfNotProvided() {
 	if "" == lc.SrcDir {
 		lc.SrcDir = fmt.Sprintf(defaultSrcDir, lc.Language)
 	}
-	if "" == lc.WorkDir {
-		lc.WorkDir = fmt.Sprintf(defaultWorkDir, lc.Language)
-	}
-	if "" == lc.AppName {
-		lc.AppName = fmt.Sprintf(defaultAppName, lc.Language)
-	}
-	if "" == lc.YamlImagePlaceholder {
-		lc.YamlImagePlaceholder = fmt.Sprintf(defaultYamlImagePlaceHolder, lc.Language)
-	}
-}
-
-// Run runs command and fail if it failed
-func (c *Command) Run(t *testing.T) {
-	args := strings.Split(c.Args, " ")
-	if output, err := exec.Command(c.Exec, args...).CombinedOutput(); err != nil {
-		t.Fatalf("Error executing: '%s' '%s' -err: '%v'", c.Exec, c.Args, strings.TrimSpace(string(output)))
-	}
 }
 
 // GetConfigs parses a config yaml file and return AllConfigs struct