refactor(app): settings urls

Author: krystxf

apps/mobile/metro-now/common/const/github.const.swift

@@ -0,0 +1,4 @@
+// metro-now
+// https://github.com/krystxf/metro-now
+
+let GITHUB_URL = "https://github.com/krystxf/metro-now"

apps/mobile/metro-now/common/const/review-url.const.swift

@@ -0,0 +1,8 @@
+// metro-now
+// https://github.com/krystxf/metro-now
+
+import Foundation
+
+let REVIEW_URL = URL(
+    string: "https://itunes.apple.com/us/app/metro-now/id6504659402?mt=8&action=write-review"
+)

apps/mobile/metro-now/metro-now.xcodeproj/project.pbxproj

@@ -57,6 +57,8 @@
 				"components/route-label-view/get-color-by-route-name.utils.swift",
 				"components/route-label-view/route-type.enum.swift",
 				const/endpoint.const.swift,
+				const/github.const.swift,
+				"const/review-url.const.swift",
 				"types/api-types.swift",
 				utils/array.utils.swift,
 				"utils/get-platform-label.swift",
@@ -73,6 +75,8 @@
 				"components/route-label-view/route-name.view.swift",
 				"components/route-label-view/route-type.enum.swift",
 				const/endpoint.const.swift,
+				const/github.const.swift,
+				"const/review-url.const.swift",
 				"types/api-types.swift",
 				utils/array.utils.swift,
 				"utils/find-closest-stop.swift",

apps/mobile/metro-now/metro-now/pages/settings/components/settings-page-about-section.view.swift

@@ -3,23 +3,13 @@
 
 import SwiftUI
 
-private let reportBugUrl = URL(
-    string: "https://github.com/krystxf/metro-now/issues/new?assignees=&labels=&projects=&template=bug_report.md&title="
-)
-
-private let requestFeatureUrl = URL(
-    string: "https://github.com/krystxf/metro-now/issues/new?assignees=&labels=&projects=&template=feature_request.md&title="
-)
-
 private let appStoreUrl = URL(
     string: "https://apps.apple.com/cz/app/metro-now/id6504659402?platform=iphone"
 )
 
-private let appStoreReviewUrl = URL(
-    string: "https://itunes.apple.com/us/app/metro-now/id6504659402?mt=8&action=write-review"
-)
-
 struct SettingsPageAboutSectionView: View {
+    let version = getFormattedVersionNumber()
+
     var body: some View {
         Section(
             header: Label("About", systemImage: "info.circle")
@@ -33,10 +23,8 @@ struct SettingsPageAboutSectionView: View {
                 }
             }
 
-            if let appStoreReviewUrl {
-                Link(
-                    destination: appStoreReviewUrl
-                ) {
+            if let REVIEW_URL {
+                Link(destination: REVIEW_URL) {
                     Label(
                         "Give us a rating",
                         systemImage: "star"
@@ -45,7 +33,10 @@ struct SettingsPageAboutSectionView: View {
                 .accessibilityHint("Opens app rating in app store")
             }
 
-            if let reportBugUrl {
+            if let reportBugUrl = getGithubIssueUrl(
+                template: .bug_report,
+                title: "Bug in version \(version)"
+            ) {
                 Link(destination: reportBugUrl) {
                     Label(
                         "Report bug",
@@ -55,8 +46,10 @@ struct SettingsPageAboutSectionView: View {
                 .accessibilityHint("Opens Github issue form")
             }
 
-            if let requestFeatureUrl {
-                Link(destination: requestFeatureUrl) {
+            if let featureRequestUrl = getGithubIssueUrl(
+                template: .feature_request
+            ) {
+                Link(destination: featureRequestUrl) {
                     Label(
                         "Feature request",
                         systemImage: "star.bubble"

apps/mobile/metro-now/metro-now/pages/settings/components/settings-page-footer.view.swift

@@ -6,17 +6,13 @@ import SwiftUI
 struct SettingsPageFooterView: View {
     var body: some View {
         VStack {
-            let versionNumber = Bundle.main.versionNumber ?? ""
-            let buildNumber = Bundle.main.buildNumber ?? ""
-            let formattedVersion = "\(versionNumber)(\(buildNumber))"
-
             Text("metro-now")
 
             Text("version: ")
-                + Text(formattedVersion).fontDesign(.monospaced)
+                + Text(getFormattedVersionNumber()).fontDesign(.monospaced)
 
             Text(
-                "[source code](https://github.com/krystxf/metro-now)"
+                "[source code](\(GITHUB_URL))"
             )
         }
     }

apps/mobile/metro-now/metro-now/pages/settings/utils/get-formatted-version-number.swift

@@ -0,0 +1,23 @@
+// metro-now
+// https://github.com/krystxf/metro-now
+
+import Foundation
+
+func getFormattedVersionNumber() -> String {
+    let version = Bundle.main.versionNumber
+    let build = Bundle.main.buildNumber
+
+    guard let version else {
+        if let build {
+            return "(\(build))"
+        } else {
+            return "uknknown version"
+        }
+    }
+
+    if let build {
+        return "\(version)(\(build))"
+    }
+
+    return version
+}

apps/mobile/metro-now/metro-now/pages/settings/utils/github.utils.swift

@@ -0,0 +1,27 @@
+// metro-now
+// https://github.com/krystxf/metro-now
+
+import Foundation
+
+enum GithubIssueTemplate: String {
+    case bug_report
+    case feature_request
+}
+
+func getGithubIssueUrl(template: GithubIssueTemplate, title: String = "") -> URL? {
+    let url = URL(string: "\(GITHUB_URL)/issues/new")
+
+    guard let url else {
+        return nil
+    }
+
+    let urlWithQueryParams = url.appending(queryItems: [
+        URLQueryItem(name: "assignees", value: nil),
+        URLQueryItem(name: "labels", value: nil),
+        URLQueryItem(name: "projects", value: nil),
+        URLQueryItem(name: "template", value: "\(template.rawValue).md"),
+        URLQueryItem(name: "title", value: title),
+    ])
+
+    return urlWithQueryParams
+}