-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Day/Night theme functionality should be extracted. #3
Comments
Thanks for your reporting:
That's not my mind... I don't know why
That's right. I've ever considered about making switching function independent from
That's a good idea~:heart: but I need some free time to see how to write a minor mode for Emacs. [TODO]
If user isn't interesting in |
Ah, see I haven't used Try some other theme packages and see how they behave. Most will not change the theme, but will then show up when you run |
So I think there are actually two problems.
When I get a chance I'll try to whip something up that could be a minor Thanks for taking a shoot at a fix!
|
In fact, I'm just testing if the commit can fix the problem, so waiting for MELPA build it and tried to install it via package.el.
Sorry, I still haven't understand the concept of Lisp's macro (errrrr...) so I don't know how should I fix this.
That's TOO thanks you! 🙏 I think I definitely need spending times to learn how to write a minor/major mode for Emacs...
Ja....Leave it until someone complains XD
No no no, I really need to apologize that I left this issue for so many days... And thanks you spending times on report issues. 🙏 |
I think that is non-theme related feature. And we already have module for this functionality - https://github.com/hadronzoo/theme-changer |
I still have this issue, third-part packages should not change Emacs behavior during compiling (or even loading with |
When you install the moe-theme from MELPA, for some reason the light theme gets loaded. I feel that a theme should not do this.
I like your idea for a day and nigh theme, but would you at all consider making that functionality its own package that is not integrated wit the theme? That is you could easily make a minor-mode that simply has two variables—possibly
daytime-theme
andnighttime-theme
—and sets the themes accordingly?Then when this minor mode s activated, the theme choice is ignored.
I mean, the bigger issue is that I should be able to install just the moe-themes (light and dark) without having to worry about the day and night code.
The text was updated successfully, but these errors were encountered: