Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configure the vmm-sandboxer's log level in the config file #35

Closed
flyflypeng opened this issue Jun 29, 2023 · 0 comments · Fixed by #36
Closed

Support configure the vmm-sandboxer's log level in the config file #35

flyflypeng opened this issue Jun 29, 2023 · 0 comments · Fixed by #36
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@flyflypeng
Copy link
Member

What would you like to be added?

Add a new config field under '[sandbox]' module in the config toml file:

[sandbox]
# Set the vmm-sandboxer process's log level
# The valid log_level value is: "error", "warn", "info", "debug", "trace"
# Default log level is "info"
log_level = "info"

Why is this needed?

Currently, vmm-sandboxer's log_level is specified by RUST_LOG env when starting the vmm-sandboxer process.
But it is not a good way to configure the vmm-sandboxer's log_level especially when running vmm-sandboxer process as a systemd service.
So we want to add a more flexible method to configure the vmm-sandboxer's log level in the config file.
@flyflypeng flyflypeng added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 29, 2023
flyflypeng added a commit to flyflypeng/kuasar that referenced this issue Jun 29, 2023
@flyflypeng
[vmm]: support configure log_level in the config file
d4e59bc 
fix kuasar-io#35

reason: Add 'sandbox.log_level' field in the config file to
support configure the vmm-sandboxer process log level.

Signed-off-by: flyflypeng <[email protected]>
@flyflypeng flyflypeng mentioned this issue Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vmm]: support configure log_level in the config file flyflypeng/kuasar
1 participant
@flyflypeng