Skip to content

WIP#3998

Closed
cpetersen5 wants to merge 32 commits intodevelopfrom
cdp/akp-kubecost-deploy
Closed

WIP#3998
cpetersen5 wants to merge 32 commits intodevelopfrom
cdp/akp-kubecost-deploy

Conversation

@cpetersen5
Copy link
Copy Markdown
Contributor

Release Notes Headline

Commentary for Reviewers

Links to Issues or Tickets

User Impact and Risks

Testing

Documentation Updates

@cpetersen5 cpetersen5 closed this Apr 9, 2025
@cpetersen5 cpetersen5 force-pushed the cdp/akp-kubecost-deploy branch from 693996a to da8b0c5 Compare April 9, 2025 19:38
@ameijer ameijer reopened this Apr 9, 2025
@thomasvn
Copy link
Copy Markdown
Member

@cpetersen5 @ameijer Let me know if you need any assistance with the NGINX config! It looks like the main changes in this config file, are to remove all routing towards the kubecost-cost-analyzer.kubecost.svc.cluster.local:9003 service.

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Apr 16, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5478002 Triggered Microsoft Teams webhook 1f1da34 cost-analyzer/templates/cost-analyzer-frontend-config-map-template.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

@github-actions github-actions Bot added the stale label Jul 31, 2025
@cpetersen5 cpetersen5 closed this Jul 31, 2025
@cpetersen5 cpetersen5 deleted the cdp/akp-kubecost-deploy branch July 31, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants