New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 部署脚本缺少必要的终止判断 #182

Open

caoyingjunz opened this issue Oct 28, 2022 · 1 comment

Assignees

Contributor

caoyingjunz commented Oct 28, 2022

kubecube 部署的时候，有不少过程是上一步运行失败，但是不中断，继续往下执行，导致后面失败的问题。。

类似helm 执行失败后，应该终止shell，而不是进入下一步
https://github.com/kubecube-io/kubecube-installer/blob/main/install_kubecube.sh#L121

caoyingjunz assigned zhujf1989

zhujf1989 assigned weilaaa and unassigned zhujf1989

Member

weilaaa commented Oct 31, 2022

是的，panic 行为应该主动失败。并且我们应该尽量保证安装行为的幂等

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment