Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transalte current CloudHub docs to Chinese. #599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Transalte current CloudHub docs to Chinese. #599

wants to merge 1 commit into from

Conversation

bettermultiply
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #584

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    I update the current CloudHub docs.

  • What is the current behavior? (You can also link to an open issue here)
    English in Chinese version

  • What is the new behavior (if this is a feature change)?
    Chinese in Chinese version

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dingyin after the PR has been reviewed.
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot
Copy link
Collaborator

Welcome @bettermultiply! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2024
@bettermultiply
Copy link
Author

Hello, I am learning about using KubeEdge, so I think translate its documentation is the best way to do that. But I have some question when translating this page.

  1. What is the channelQ mean? is it a typo? (I can't find any other words like 'channelQ' in any other files either in kubeedge/kubeedge and kubeedge/website source code.)
  2. It is apparently that current content is describing the WebSocket ways to connoect. Does it need to change the structure of the article to inform the readers?(I am not so familiar with the CloudHub now, so I have no confidence to change the content instead of translating without error.)

@magichan
Copy link
Contributor

magichan commented Aug 17, 2024 •
edited
Loading

Hello, I am learning about using KubeEdge, so I think translate its documentation is the best way to do that. But I have some question when translating this page.

  1. What is the channelQ mean? is it a typo? (I can't find any other words like 'channelQ' in any other files either in kubeedge/kubeedge and kubeedge/website source code.)
  2. It is apparently that current content is describing the WebSocket ways to connoect. Does it need to change the structure of the article to inform the readers?(I am not so familiar with the CloudHub now, so I have no confidence to change the content instead of translating without error.)

channelQ is a concept from the early versions. I checked the commit history and confirmed that it was replaced by dispatcher during the cloudhub refactoring in release-1.12.

magichan
magichan reviewed Aug 17, 2024
View reviewed changes
i18n/zh/docusaurus-plugin-content-docs/current/architecture/cloud/cloudhub.md

CloudHub is one module of cloudcore and is the mediator between Controllers and the Edge side. It supports both web-socket based connection as well as a [QUIC](https://quicwg.org/ops-drafts/draft-ietf-quic-applicability.html) protocol access at the same time.
The edgehub can choose one of the protocols to access to the cloudhub. CloudHub's function is to enable the communication between edge and the Controllers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content of CloudHub's function is to enable the communication between edge and the Controllers is missing

i18n/zh/docusaurus-plugin-content-docs/current/architecture/cloud/cloudhub.md
- 获取消息上下文并为事件创建 ChannelQ
- 通过 WebSocket 创建 HTTP 连接
- 保持 WebSocket 连接
- 从读取边缘信息
Copy link
Contributor

@magichan magichan Aug 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从读取边缘信息 -> 从边缘端读取信息

i18n/zh/docusaurus-plugin-content-docs/current/architecture/cloud/cloudhub.md
- 通过 WebSocket 创建 HTTP 连接
- 保持 WebSocket 连接
- 从读取边缘信息
- 向边缘写入信息
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i perfer to 边缘侧

i18n/zh/docusaurus-plugin-content-docs/current/architecture/cloud/cloudhub.md

### Read message from edge:
### 从读取边缘信息:
Copy link
Contributor

@magichan magichan Aug 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从读取边缘信息->从边缘端读取信息

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magichan magichan magichan left review comments

@anvithks anvithks Awaiting requested review from anvithks

@fisherxu fisherxu Awaiting requested review from fisherxu

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Chinese documentation of kubeedge
3 participants
@bettermultiply @kubeedge-bot @magichan