Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

[Model Sync] Needs Sync Needs to take into account open PR #174

Open
jlewi opened this issue Jul 16, 2020 · 6 comments
Open

[Model Sync] Needs Sync Needs to take into account open PR #174

jlewi opened this issue Jul 16, 2020 · 6 comments
Labels

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 16, 2020

Right now needs sync only compares the latest model to the model on master.

As a result, we end up firing off a Tekton pipeline if there is a PR open with a pending update. We should detect that and not fire off a pipeline.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.53

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Jul 16, 2020

@hamelsmu Do you know offhand if there is a good way to encode metadata in a PR?

@jlewi
Copy link
Contributor Author

jlewi commented Jul 16, 2020

I didn't see anything in the payload.
https://developer.github.com/v4/object/pullrequest/

I think we will just have to put data into the title and comment and use that to look for PRs.

@hamelsmu
Copy link
Member

@jlewi I am not 100% sure what you are looking for. Can you describe it in a bit more detail?

@jlewi
Copy link
Contributor Author

jlewi commented Jul 16, 2020

@hamelsmu I'd like to be able to programmatically identify if the bot had previously opened a PR to update a model to a specific version. So the easiest thing would be if it was easy to annotate the PR with some machine readable metadata; i.e. a json object containing whatever metadata the bot needs.

It looks like the only way to encode information on a PR would be in the comment itself but maybe I'm missing something.

@hamelsmu
Copy link
Member

Yes you are correct

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants