tensorboard fails to connect if there is a notebook with the same name

[thesuperzapper]

/kind bug

Currently, if you create a Notebook and Tensorboard resource with the same name (in the same namespace), then Istio will not correctly route the traffic to one or the other.

This is caused by the notebook/tensorboard controllers both trying to use the name of the notebook/tensorboard as the name of the Service, in addition to not having a specific enough Pod label selector (notebooks uses statefulset: {notebook_name} and tensorboard uses app: {tensorboard_name}) which is clearly way too broad.

While we are fixing this, we should also have the tensorboard controller name its VirtualServices tensorboard-{tensorboard_name} (rather than just the name of the tensorboard, which could overlap). Note, the notebooks controller already uses notebook-{namespace_name}-{notebook_name} for its VirtualService names.

[andreyvelich]

/transfer dashboard

[google-oss-prow]

@thesuperzapper: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug

Currently, if you create a Notebook and Tensorboard resource with the same name (in the same namespace), then Istio will not correctly route the traffic to one or the other.

This is caused by the notebook/tensorboard controllers both trying to use the name of the notebook/tensorboard as the name of the Service, in addition to not having a specific enough Pod label selector (notebooks uses statefulset: {notebook_name} and tensorboard uses app: {tensorboard_name}) which is clearly way too broad.

While we are fixing this, we should also have the tensorboard controller name its VirtualServices tensorboard-{tensorboard_name} (rather than just the name of the tensorboard, which could overlap). Note, the notebooks controller already uses notebook-{namespace_name}-{notebook_name} for its VirtualService names.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.