[backend] Inverted condition in get_container_name function makes return unreachable

[ai-naymul]

ref:

kale/kale/common/podutils.py

Line 123 in 95e97ac

if len(candidates) > 0:

When filtering out sidecar containers leaves exactly one candidate (the expected success case), the function raises "No container names left" instead of returning the candidate. When candidates is empty, it falls through to candidates[0] which raises an IndexError.

Expected: if len(candidates) == 0 so that one remaining candidate is returned successfully.

[ai-naymul]

@ada333 @ederign

taking this and also found another issue while working on this..:

In kale/rpc/kfp.py...
ref:

kale/kale/rpc/kfp.py

Line 87 in 95e97ac

while pipeline_id is None or token is not None:

The same function in kfputils.py correctly uses and..

ref:

kale/kale/common/kfputils.py

Line 60 in 95e97ac

while pipeline_id is None and token is not None:

With or, once the pipeline is found (pipeline_id is set), the loop keeps going through all remaining pages instead of stopping. If the API keeps returning a next_page_token, this could loop indefinitely.

[ai-naymul]

/assign