You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What steps did you take and what happened:
For the exit handler example, the Tekton version right now treat it as a failed pipeline and stop all task scheduling. However, the Argo version simply skip the exit handler dag and continue the pipeline as a succeed pipeline. We need to get some user feedbacks and data on which way they prefer the exit handler should behave.
Currently the Tekton implementation follows the Tekton finally logic and Argo is just skipping the whole exit handler sub-dag. Both are viable implementation which we need some feedbacks from actual users.
What did you expect to happen:
Additional information:
[Miscellaneous information that will assist in solving the issue.]
Environment:
Python Version (use python --version):
SDK Version:
Tekton Version (use tkn version):
Kubernetes Version (use kubectl version):
OS (e.g. from /etc/os-release):
The text was updated successfully, but these errors were encountered:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
fail-op is a regular task and it should not be inside the finally of a PipelineRun. The current implementation is reasonable.
The major difference between Argo v2 and Tekton v2 is the pipeline with a failed task has a different final status
In Tekton, the final status is Failed
In Argo, the final status is Succeeded
Tomcli
changed the title
Tekton V2 compiler should put finally graph components inside finally instead of regular tekton tasks
Tekton V2 compiler: gather user data on how the exit handler should represent
Oct 26, 2023
/kind bug
What steps did you take and what happened:
For the exit handler example, the Tekton version right now treat it as a failed pipeline and stop all task scheduling. However, the Argo version simply skip the exit handler dag and continue the pipeline as a succeed pipeline. We need to get some user feedbacks and data on which way they prefer the exit handler should behave.
Currently the Tekton implementation follows the Tekton finally logic and Argo is just skipping the whole exit handler sub-dag. Both are viable implementation which we need some feedbacks from actual users.
What did you expect to happen:
Additional information:
[Miscellaneous information that will assist in solving the issue.]
Environment:
python --version
):tkn version
):kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: