Skip to content

[feature] split up package to appengine and rest #11479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mokshasoul opened this issue Dec 20, 2024 · 2 comments
Closed

[feature] split up package to appengine and rest #11479

mokshasoul opened this issue Dec 20, 2024 · 2 comments
Labels
kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@mokshasoul
Copy link

mokshasoul commented Dec 20, 2024

Feature Area

Requirements:

Currently everyone who wants to use this package is force to use urllib < 2.0.0 which is a version although receiving security patches that doesn't play well with cloud environments (e.g. Cloud Composer).

What feature would you like to see?

Since this is an artificial limit to only support engine my suggestion would be to create a feature package (pipeline-components[app-engine], kfp[app-engine]) to support this one use-case instead of generalising it on all pain ponts

What is the use case or pain point?

We publish packages based on cloud composer requirements and this is essentially blocking dependency resolution.

Is there a workaround currently?

I'm preparing a PR that tries to solve this, but essentially short of forking this project the above approach seems a bit more reasonable

I would also like to understand why the monkeypatching is needed, and if it can be solved in a simpler way

we are also aware that we could run this in a PythonVirtualEnvironmentOperator but ideally we want to abstract this away to deferable operators in our own package


Love this idea? Give it a 👍.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Feb 19, 2025
Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
None yet
Development

No branches or pull requests

1 participant