feat(backend): Allow recurring runs to always use the latest pipeline version #11560
+459
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/cc @HumairAK |
mprahl
force-pushed
the
swf-no-pv
branch
3 times, most recently
from
5b49142 to
7ccdbad
Compare
mprahl
force-pushed
the
swf-no-pv
branch
17 times, most recently
from
0beb1b2 to
1f5dbf8
Compare
mprahl
force-pushed
the
swf-no-pv
branch
4 times, most recently
from
53d82c0 to
f6ac254
Compare
mprahl
changed the title
This makes the pipeline_version_id optional and makes the Scheduled Workflow controller levarege the REST API to launch the run rather than rely on compiled Argo Workflows stored in the ScheduledWorkflow object. The previous behavior is preserved if the user is using the v1 API or specifies a pipeline version ID or pipeline spec manifest. Resolves: kubeflow#11542 Signed-off-by: mprahl <[email protected]>
Signed-off-by: mprahl <[email protected]>
|
/lgtm tested/verified Awesome ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mprahl can we get an issue for front end support on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This makes the pipeline_version_id optional and makes the
Scheduled Workflow controller levarege the REST API to launch the run
rather than rely on compiled Argo Workflows stored in the
ScheduledWorkflow object.
The previous behavior is preserved if the user is using the v1 API or
specifies a pipeline version ID or pipeline spec manifest.
Resolves:
#11542
Checklist: