Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates a Template for new PRs #3965

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Creates a Template for new PRs #3965

wants to merge 7 commits into from

Conversation

varodrig
Copy link
Contributor

Checklist:

Description of your changes:
This PR creates a new template for new PRs similar to this description. This will help the community to understand quickly what a PR will be enhancing or resolving in the website. Additionally by linking the issue it helps reduce the issues that are not closed even thought were resolved.

Issue

Closes: #3936

Labels

/area other

@google-oss-prow Google OSS Prow
Copy link

@varodrig: The label(s) area/other cannot be applied, because the repository doesn't have them.

In response to this:

Checklist:

Description of your changes:
This PR creates a new template for new PRs similar to this description. This will help the community to understand quickly what a PR will be enhancing or resolving in the website. Additionally by linking the issue it helps reduce the issues that are not closed even thought were resolved.

Issue

Closes: #3936

Labels

/area other

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varodrig
Copy link
Contributor Author

/area other

@google-oss-prow Google OSS Prow
Copy link

@varodrig: The label(s) area/other cannot be applied, because the repository doesn't have them.

In response to this:

/area other

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varodrig
Copy link
Contributor Author

varodrig commented Jan 19, 2025 •
edited
Loading

@andreyvelich and @hbelmiro to review thank you and anyone else from the community who wants to provide feedback.
Also we need to create new labels before merging. Can you help with this?
Created an issue
#3967

@varodrig
Copy link
Contributor Author

/hold

@varodrig
Copy link
Contributor Author

cc @kubeflow/kubeflow-steering-committee @kubeflow/wg-training-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-manifests-leads @kubeflow/release-team @kubeflow/wg-data-leads @kubeflow/wg-deployment-leads

hbelmiro
hbelmiro reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'm not allowed to modify labels @varodrig.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro left review comments

@jbottum jbottum Awaiting requested review from jbottum

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@hbelmiro hbelmiro

Labels
do-not-merge/hold lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a PR template for the website
2 participants
@varodrig @hbelmiro