Clean up NuGet workflow (#768)

* create release (disable nuget push for now)

* nudge

* skip tests

* use Powershell because Windows runner

* gh version outdated?

* try ubuntu?

* Revert "try ubuntu?"

This reverts commit ee256b1.

* install it via choco?

* different command

* Revert "different command"

This reverts commit 55f31bd.

* ooh it just needs GITHUB_TOKEN

* clean up, add comment

* move further down

* re-enable everything

* indent

* fix RegEx so that it supports higher version numbers

* debug

* Revert "debug"

This reverts commit 243b820.

* confirmed that cli is on latest now. clean this up.

* nudge

* skip tests

* disable push

* Revert "disable push"

This reverts commit 143978d.

* Revert "skip tests"

This reverts commit 4362d21.

Author: MaxHorstmann

.github/workflows/nuget.yaml

@@ -41,11 +41,6 @@ jobs:
     - name: dotnet nuget push
       run: dotnet nuget push pkg\*.nupkg -s https://www.nuget.org/ -k ${{ secrets.nuget_api_key }}
 
-    # This step can be removed when GH runner has gh version 2.4.0 (2021-12-21) or higher
-    # As of 1/8/2022, runner has 2.3.0 which doesn't support --generate-notes below
-    - name: install latest gh cli 
-      run: choco install gh
-
     - name: create release
       shell: pwsh
       env: