Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags missing for v1.0 RC releases sometimes #1828

Open
stefreak opened this issue Aug 2, 2024 · 4 comments
Open

Tags missing for v1.0 RC releases sometimes #1828

stefreak opened this issue Aug 2, 2024 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@stefreak
Copy link

stefreak commented Aug 2, 2024

Describe the bug
v1.0 RC releases sometimes are missing git tags sometimes.

Only 1.0.0-rc5 and 1.0.0-rc3 have been pushed to the repository.

Additional context
Tags (And GitHub releases) can help quickly parsing the list of changes when troubleshooting an issue, or when making a decision to update.

Happy to share that we are successfully using the release-1 branch at github.com/garden-io/garden since a while and are satisfied with it, only very rarely seeing bugs related to the client.
If you need hands let us know

@brendandburns
Copy link
Contributor

Yeah, the trouble comes when I had to run the release manually instead of the github action. We should be in an ok place now.

Thanks also for the report that it is working for you. I think we're moving towards a 1.0.0 release associated with the next Kubernetes release.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 30, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Dec 19, 2024

@brendandburns it looks like this issue was still present on the 1.0.0 release - https://github.com/kubernetes-client/javascript/actions/runs/12395838409/job/34602484401.

mstruebing added a commit that referenced this issue Dec 20, 2024
We had the issue that the github action wasnt able to push
tags to github. This should fix the issue

ref: #1828
mstruebing added a commit that referenced this issue Dec 20, 2024
We had the issue that the github action wasnt able to push
tags to github. This should fix the issue

ref: #1828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants