Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-rc6 - Patch content-type override doesn't take effect #1836

Closed
impatient opened this issue Aug 13, 2024 · 1 comment
Closed

1.0.0-rc6 - Patch content-type override doesn't take effect #1836

impatient opened this issue Aug 13, 2024 · 1 comment

Comments

@impatient
Copy link

Describe the bug
Override of content type via middleware does not take effect. Had to use work around listed here.

#1499

** Client Version **
1.0.0-rc6

** Server Version **
1.28.11

To Reproduce
Attempt to set StrategicMergePatch using middleware on the 1.0 client

Expected behavior
The middleware to take effect.

** Example Code**
nullplatform/k8s-lease-lock@6b189fd#diff-d8eee3b9c50488b328e4b9805b642354ccbaefadf361cbd9bd763925ed61ebeaR50

Wrapped in authMethods as a workaround. As mentioned in linked ticket.

Environment (please complete the following information):
Node 20.11

Additional context
Other ticket closed as not planned. Would you welcome a PR with documentation on this as a workaround or add it to the examples? Also, the case of Content-Type on header seemed to need to match exactly. Assume all issues are due to the generator, but might be worth it to expose a wrapper for middleware that hides this or at least some documentation.

Likely issue: OpenAPITools/openapi-generator#14549

Not sure how often people will run into this, but wanted visibility that it was still an issue that people were running into.

@brendandburns
Copy link
Contributor

I reopened #1499 and I'm going to close this issue in favor of that issue.

We'd definitely welcome a PR to fix this. The generator team is usually very responsive to fixes in the generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants