Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic native CSI Driver should not have reference to specific vendor packages #736

Open
sean-freeman opened this issue Aug 12, 2024 · 6 comments

Comments

@sean-freeman
Copy link

What happened:

Generic native CSI Driver should not have reference to specific vendor packages. Code should not contain az specific references in code

Vendor specific code within a generic driver should not exist, unless additional handling is required for functionality with that vendor. Unnecessary dependency is created on cloud-provider-azure, with reference to cloud-provider-azure/pkg/cache as a wrapper for k8s.io/client-go/tools/cache

What you expected to happen:

N/A

How to reproduce it:

N/A

Anything else we need to know?:

Environment:

  • CSI Driver version: all
  • Kubernetes version (use kubectl version): all
  • OS (e.g. from /etc/os-release): all
  • Kernel (e.g. uname -a): all
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 10, 2024
@sean-freeman
Copy link
Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 11, 2024
@sean-freeman
Copy link
Author

@andyzhangx Please acknowledge

@andyzhangx
Copy link
Member

@sean-freeman do you have time to contribute on this?

@sean-freeman
Copy link
Author

sean-freeman commented Dec 11, 2024

@andyzhangx I am engaged in multiple other open source projects of significant scale, I cannot provide help here. I noticed this dependency problem by accident when performing K8S testing, I am not a K8S Dev and would be lost in this CSI code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants