From af1f84263546b92f8166e18479fe7b27a087509b Mon Sep 17 00:00:00 2001 From: Madhu Rajanna Date: Tue, 3 Dec 2024 06:46:26 +0100 Subject: [PATCH] replace enable-volume-group-snapshots with featuregate replace the old ref of enable-volume-group-snapshots flag with featuregate --- README.md | 10 +++++----- cmd/csi-snapshotter/main.go | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 4ef9242cc..7b7f2206b 100644 --- a/README.md +++ b/README.md @@ -119,10 +119,10 @@ Other than this, the NODE_NAME environment variable must be set where the CSI sn The following requisites must be met to enable the volume group snapshot feature: * the Volume Group Snapshot CRDs are installed in the cluster -* the `--enable-volume-group-snapshots=true` option is being passed to the snapshot controller -* the `--enable-volume-group-snapshots=true` option is being passed to the CSI snapshotter sidecar +* the `--feature-gates=CSIVolumeGroupSnapshot=true` option is being passed to the snapshot controller +* the `--feature-gates=CSIVolumeGroupSnapshot=true` option is being passed to the CSI snapshotter sidecar -Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml` needs to be updated with `--enable-volume-group-snapshots=true` in order to enable this feature in the snapshot controller. +Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml` needs to be updated with `--feature-gates=CSIVolumeGroupSnapshot=true` in order to enable this feature in the snapshot controller. ### Snapshot controller command line options @@ -159,7 +159,7 @@ Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.y #### Volume Group Snapshot support -* `--enable-volume-group-snapshots`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster. +* `--feature-gates=CSIVolumeGroupSnapshot=true`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster. #### Other recognized arguments * `--kubeconfig `: Path to Kubernetes client configuration that the snapshot controller uses to connect to Kubernetes API server. When omitted, default token provided by Kubernetes will be used. This option is useful only when the snapshot controller does not run as a Kubernetes pod, e.g. for debugging. @@ -205,7 +205,7 @@ Specifically, `deploy/kubernetes/snapshot-controller/setup-snapshot-controller.y #### Volume Group Snapshot support -* `--enable-volume-group-snapshots`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster. +* `--feature-gates=CSIVolumeGroupSnapshot=true`: Enables support for Volume Group Snapshots. If this option is enabled, the VolumeGroupSnapshots CRD should be available on the cluster. #### Other recognized arguments * `--kubeconfig `: Path to Kubernetes client configuration that the CSI external-snapshotter uses to connect to Kubernetes API server. When omitted, default token provided by Kubernetes will be used. This option is useful only when the external-snapshotter does not run as a Kubernetes pod, e.g. for debugging. diff --git a/cmd/csi-snapshotter/main.go b/cmd/csi-snapshotter/main.go index b8b907cc9..e54680f7b 100644 --- a/cmd/csi-snapshotter/main.go +++ b/cmd/csi-snapshotter/main.go @@ -250,7 +250,7 @@ func main() { if err != nil { klog.Errorf("error determining if driver supports create/delete group snapshot operations: %v", err) } else if !supportsCreateVolumeGroupSnapshot { - klog.Warningf("CSI driver %s does not support GroupControllerCreateVolumeGroupSnapshot when the --enable-volume-group-snapshots flag is true", driverName) + klog.Warningf("CSI driver %s does not support GroupControllerCreateVolumeGroupSnapshot when the --feature-gates=CSIVolumeGroupSnapshot=true flag is set", driverName) } groupSnapshotter = group_snapshotter.NewGroupSnapshotter(csiConn) if len(*groupSnapshotNamePrefix) == 0 {