Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Fix recording events #142

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix recording events #142

wants to merge 1 commit into from

Conversation

kvaps
Copy link

@kvaps kvaps commented Aug 1, 2024 •
edited
Loading

This PR fixes issue with recording events in different namespaces

as part of kubernetes-retired/container-object-storage-interface-api#85
fixes #140

@k8s-ci-robot k8s-ci-robot requested a review from BlaineEXE August 1, 2024 15:12
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kvaps
Once this PR has been reviewed and has the lgtm label, please assign mukhoakash for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang August 1, 2024 15:12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2024
@kvaps kvaps marked this pull request as draft August 1, 2024 15:13
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2024
@kvaps kvaps changed the title Fix recreating BucketAccess with Update method Fix recording events Aug 1, 2024
@BlaineEXE
Copy link
Contributor

BlaineEXE commented Aug 1, 2024 •
edited
Loading

@kvaps we really appreciate your contribution. There is a complication that makes this challenging right now. We are in the process of migrating from separate API/spec/controller/sidecar repos into a monorepo at https://github.com/kubernetes-sigs/container-object-storage-interface-api. We are still working on merging the controller into the monorepo, and the sidecar will come after that.

[edit] I've realized this PR is just a change to modify the import. I will direct my review/focus to kubernetes-retired/container-object-storage-interface-api#85

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events can't be created different namespaces
4 participants
@kvaps @k8s-ci-robot @BlaineEXE @k8s-triage-robot