Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Shield advanced on NLBs not part of ingress controller #3752

Open
uk-rj opened this issue Jun 21, 2024 · 4 comments · May be fixed by #3869
Open

Support AWS Shield advanced on NLBs not part of ingress controller #3752

uk-rj opened this issue Jun 21, 2024 · 4 comments · May be fixed by #3869
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@uk-rj
Copy link

uk-rj commented Jun 21, 2024

Currently the ALB controller supports an annotation to enable AWS Shield Advanced for ALB / Ingress resource.
alb.ingress.kubernetes.io/shield-advanced-protection

AWS Shield Advanced is also available for NLBs, it would be great if you could provide and annotation and support for enabling of shield-advanced-protection on NLBs created using the service resource. I guess it would also need to provision an elastic IP, linked to the NLB, for advanced shield to work.

@shethyogita83
Copy link
Contributor

Hello @uk-rj,

Thanks for your feature request to add AWS Shield Advanced support for NLBs on AWS load balancer controller.

We will discuss this with our internal team and see if we can add it to our roadmap.

Thanks

@shraddhabang shraddhabang added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jun 26, 2024
@csauoss
Copy link

csauoss commented Jul 15, 2024

@shethyogita83 @shethyogita83 If this is open for contribution, I would like to pick this issue.

@shethyogita83
Copy link
Contributor

Hey @csauoss, Thanks for reaching out and offering to pick up the issue!

Yes, this issue is open for contribution and you can pick it up.

We will be waiting for your PR.

Thanks!

@csauoss csauoss linked a pull request Sep 28, 2024 that will close this issue
6 tasks
@csauoss
Copy link

csauoss commented Sep 28, 2024

@shethyogita83 I have the pr #3869 out for this. Took me longer than expected as I was occupied with some things. Can you please suggest me a simple way to test this manually and also review the pr when you get a chance?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants