Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license boilerplate to .go files and add boilerplate checking scripts from kubernetes projects. #564

Open
cprivitere opened this issue Jun 27, 2024 · 3 comments
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cprivitere
Copy link
Member

Many of our .go files are missing required Apache 2.0 boilerplate text required by the Kubernetes project standards. Proposed solution:

  1. Add the text.
  2. Look at a kubernetes project like cluster-api and add the boilerplate verification scripts they use to this project to ensure future commits have the required text.
@cprivitere
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 27, 2024
@displague
Copy link
Member

displague commented Jun 27, 2024

The EMLB openapitools-cli generated SDK files (#476) may stand as an exception to the Apache licenses that would be applied on the files in this project (also relevant for CAPP). This generated SDK has been artifacted in other projects ahead of and alongside CPEM and CAPP, including https://github.com/equinix/metal-cli/pull/362/files and private repos in my personal GitHub org under an MIT license - https://github.com/displague/metal-lbaas-go (not published to avoid dependency).

The long-term intent with the ELMB SDK files is that they would be imported into this project from an outside repository where the files are licensed under a compatible license (very likely MIT, following the equinix-sdk-go pattern).

https://github.com/equinix/equinix-sdk-go/blob/main/LICENSE

If necessary, the files can be dual licensed AS MIT and Apache. Or, until these files are sources from equinix-sdk-go (or similar) the Copyright may be assigned to Equinix SDK Authors primarily and Kubernetes Authors secondarily for the SDK files modified within CAPP and CPEM.

@displague
Copy link
Member

If the files can coexist in both repositories with alternate Copyright holders, a single author should also be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants