Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update self-managed templates to use internal LB for node-to-node communication #5210

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Update self-managed templates to use internal LB for node-to-node communication #5210

merged 1 commit into from
Nov 5, 2024

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Oct 24, 2024 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • This PR aims to update self-managed templates hosted by CAPZ.
  • The self managed templates will now use the Internal LB for node-node communication.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes: #5301

Special notes for your reviewer:

  • Next will update managed K8s templates.

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update self-managed templates to use internal LB for node-to-node communication

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.78%. Comparing base (90d9b4b) to head (d753715).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5210   +/-   ##
=======================================
  Coverage   52.78%   52.78%           
=======================================
  Files         270      270           
  Lines       29060    29060           
=======================================
  Hits        15340    15340           
  Misses      12928    12928           
  Partials      792      792

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2024
@nawazkh nawazkh force-pushed the update_dev_templates branch 2 times, most recently from c339bf3 to 8aaedd3 Compare October 25, 2024 00:00
@nawazkh nawazkh marked this pull request as ready for review October 25, 2024 00:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
@nawazkh nawazkh mentioned this pull request Oct 25, 2024
Merged
4 tasks
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 25, 2024

Why don't we want the changes from #5209 for these templates?

@nawazkh

This comment was marked as outdated.

Sign in to view
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 25, 2024

Do these templates produce nodes that can communicate with the control plane without the fix from #5209?

@nawazkh

This comment was marked as outdated.

Sign in to view
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 25, 2024

I think that coupling with the default template is intended exactly for the kinds of changes we're making to look here. With the approach in this PR, we'll now need to copy-paste those same patches defined for the default template in #5209 to these four other templates, vs. defining them once in the default template and letting them propagate to these other templates automatically.

@nawazkh
Copy link
Member Author

nawazkh commented Oct 25, 2024

A change like #5209 needs to be propagated across all templates and not just to these four flavors.
This PR just cleans up the way each flavor is built.

@nawazkh
Copy link
Member Author

nawazkh commented Oct 30, 2024

WIP, hold.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2024
@nawazkh nawazkh closed this Oct 30, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Nov 1, 2024

/cc @nojnhuh

willie-yao
willie-yao approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your hard work on this @nawazkh! 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2a2db7f01260922d926b5c9f53efd10da7ca9a3

@willie-yao
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 1, 2024
@nawazkh
reference ILB changes from common dir
d753715 
- bastion, azure cni v1, ephemeral, edgezone are independent of default templates
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2024
@willie-yao
Copy link
Contributor

/lgtm

Good catch @mboersma!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c9ac0c622c85f65a06e57d56c55294a4bc1bd32

mboersma
mboersma approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nawazkh
Copy link
Member Author

nawazkh commented Nov 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Nov 5, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit e2ad4e2 into kubernetes-sigs:main Nov 5, 2024
29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 5, 2024
@nawazkh nawazkh deleted the update_dev_templates branch November 5, 2024 05:10
@jackfrancis jackfrancis mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@mboersma mboersma

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Update VM based templates to have internal LB IP
5 participants
@nawazkh @k8s-ci-robot @nojnhuh @willie-yao @mboersma