[v0.10.6] OpenStackCluster stuck on deletion when failing to resolve bastion image

[lentzi90]

/kind bug

What steps did you take and what happened:

1. Create a cluster
2. Make sure bastion is enabled and using an image that doesn't exist OR a filter that selects multiple images
3. Delete the cluster
4. The cluster stays deleting forever. The OpenStackCluster cannot be deleted because CAPO cannot resolve the bastion image.

Code:

cluster-api-provider-openstack/controllers/openstackcluster_controller.go

Lines 155 to 158 in 4d9dadf

	// Attempt to resolve bastion resources before delete. We don't need to worry about starting if the resources have changed on update.
	if _, err := resolveBastionResources(scope, clusterResourceName, openStackCluster); err != nil {
	return reconcile.Result{}, err
	}

What did you expect to happen:

Anything else you would like to add:

This issue is not present in v0.11.

Environment:

• Cluster API Provider OpenStack version (Or git rev-parse HEAD if manually built): v0.10.6
• Cluster-API version:
• OpenStack version:
• Minikube/KIND version:
• Kubernetes version (use kubectl version):
• OS (e.g. from /etc/os-release):