Add KubeadmControlPlanePhase to CRD

[sivchari]

What would you like to be added (User Story)?

I suggest to add KubeadmControlPlanePhase to CRD.
Currently, Cluster and MachineDeployment has individual phase, but KCP doesn't have it.
KCP is same as MachineDeployment, because ControlPlane is machine, too.

Detailed Description

TBW

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

[k8s-ci-robot]

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fabriziopandini]

@sivchari which phases do you envision for KCP? how they are defined?

[sivchari]

I want Scaling Up, Scaling Down and Running phase. This phase is changed following and changing by replicas and other field.

[chrischdi]

You should be able to take a look at the ResizedCondition of a KCP:

cluster-api/controlplane/kubeadm/api/v1beta1/condition_consts.go

Line 61 in 88905d4

ResizedCondition clusterv1.ConditionType = "Resized"

It is getting set here:

cluster-api/controlplane/kubeadm/internal/controllers/status.go

Lines 65 to 86 in 88905d4

	switch {
	// We are scaling up
	case replicas < desiredReplicas:
	conditions.MarkFalse(controlPlane.KCP, controlplanev1.ResizedCondition, controlplanev1.ScalingUpReason, clusterv1.ConditionSeverityWarning, "Scaling up control plane to %d replicas (actual %d)", desiredReplicas, replicas)
	// We are scaling down
	case replicas > desiredReplicas:
	conditions.MarkFalse(controlPlane.KCP, controlplanev1.ResizedCondition, controlplanev1.ScalingDownReason, clusterv1.ConditionSeverityWarning, "Scaling down control plane to %d replicas (actual %d)", desiredReplicas, replicas)
	// This means that there was no error in generating the desired number of machine objects
	conditions.MarkTrue(controlPlane.KCP, controlplanev1.MachinesCreatedCondition)
	default:
	// make sure last resize operation is marked as completed.
	// NOTE: we are checking the number of machines ready so we report resize completed only when the machines
	// are actually provisioned (vs reporting completed immediately after the last machine object is created).
	readyMachines := controlPlane.Machines.Filter(collections.IsReady())
	if int32(len(readyMachines)) == replicas {
	conditions.MarkTrue(controlPlane.KCP, controlplanev1.ResizedCondition)
	}
	// This means that there was no error in generating the desired number of machine objects
	conditions.MarkTrue(controlPlane.KCP, controlplanev1.MachinesCreatedCondition)
	}

And from quickly reading it, the condition should either be:

• True: if all kcp machines are ready
• False with controlplanev1.ScalingUpReason for scaling up.
• False with controlplanev1.ScalingDownReason for scaling down.

[sivchari]

I didn't know this condition so far, thanks. Then why does MachineDeployment has conditions and phase ?

[chrischdi]

Good question, maybe searching the PRs which introduced the one or the other or the ones for the proposals and reading through them may have context on that.