Drop two ways contract for machine's failure domain

[fabriziopandini]

Since 0.3.0 we are supporting a two ways contract for machine's failure domain, which is really confusing.

Most specifically, we are supporting a deprecated reverse process where InfraMachine was authoritative WRT to failure domain placement (this was implemented for allowing a transparent transition from when there was no failure domain support in Cluster API)

This issue is about creating awareness on the fact that we are going to drop the reverse process entirely with v1beta2.

I also already added an heads up warning to the infra machine contract page in #11223

Rif
https://github.com/kubernetes-sigs/cluster-api/blame/274d7e21e1ac2eb89b3f5986f6a09ff9db4eeacc/internal/controllers/machine/machine_controller_phases.go#L324-L333

/kind cleanup
/priority important-soon
/triage accepted
/help

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added (User Story)?

Since 1.3.0 we are supporting a two ways contract for machine's failure domain, which is really confusing.

Most specifically, we are supporting a deprecated reverse process where InfraMachine was authoritative WRT to failure domain placement (this was implemented for allowing a transparent transition from when there was no failure domain support in Cluster API)

This issue is about creating awareness on the fact that we are going to drop the reverse process entirely with v1beta2.

I also already added an heads up warning to the infra machine contract page in #11223

Detailed Description

xx

Anything else you would like to add?

No response

Label(s) to be applied

/kind cleanup
/priority important-soon
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hackeramitkumar]

/assign

[hackeramitkumar]

@fabriziopandini Is there more code to be removed other than this ?
https://github.com/kubernetes-sigs/cluster-api/blame/274d7e21e1ac2eb89b3f5986f6a09ff9db4eeacc/internal/controllers/machine/machine_controller_phases.go#L324-L333