Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal IPv6 addresses are used when ExternalAddress is specified. #4807

Open
TroyKomodo opened this issue Oct 15, 2024 · 3 comments · May be fixed by #4808
Open

Internal IPv6 addresses are used when ExternalAddress is specified. #4807

TroyKomodo opened this issue Oct 15, 2024 · 3 comments · May be fixed by #4808
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@TroyKomodo
Copy link

TroyKomodo commented Oct 15, 2024

683663e#diff-14de035cd51595a543622295768037ac376d511bc269c0f41f36cd6737db01bdR84

(

if address.Type == v1.NodeExternalIP || (address.Type == v1.NodeInternalIP && suitableType(address.Address) == endpoint.RecordTypeAAAA) {
)

This commit introduced a change which checks if the ipv6 address is internal and uses it regardless of if we only want external ips. This seems very wrong.

I patched this out on my build and use a custom image.

@TroyKomodo TroyKomodo added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2024
@TroyKomodo
Copy link
Author

image image

@TroyKomodo
Copy link
Author

apiVersion: v1
kind: Service
metadata:
  name: headless
  namespace: app
  labels:
    app: cdn
  annotations:
    external-dns.alpha.kubernetes.io/endpoints-type: NodeExternalIP
    external-dns.alpha.kubernetes.io/hostname: "..."
    external-dns.alpha.kubernetes.io/cloudflare-proxied: "false"
spec:
    ...

TroyKomodo added a commit to TroyKomodo/external-dns that referenced this issue Oct 15, 2024
@TroyKomodo TroyKomodo linked a pull request Oct 15, 2024 that will close this issue
2 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants