NS record not being created via CRD

[drew-viles]

What happened:
I'm trying to create an NS record as advised via the docs here.
Here is my resource (redacted of course):

apiVersion: externaldns.k8s.io/v1alpha1
kind: DNSEndpoint
metadata:
  name: infer-dns-ns
  namespace: infer-dns
spec:
  endpoints:
  - dnsName: some-domain.example.com
    recordTTL: 300
    recordType: NS
    targets:
    - ns1.delegation.example.com

When I deploy this, nothing happens. The logs state msg="All records are already up to date". I have the --source=crd set too which I have validated as working by adjusting my DNSEndpoint to test it - for example, this works:

apiVersion: externaldns.k8s.io/v1alpha1
kind: DNSEndpoint
metadata:
  name: infer-dns-ns
  namespace: infer-dns
spec:
  endpoints:
  - dnsName: some-domain.example.com
    recordTTL: 300
    recordType: A
    targets:
    - 0.0.0.0

What you expected to happen:
The NS record should be created as per the docs.

How to reproduce it (as minimally and precisely as possible):
Just deploy external dns via the helm chart with the following values:

releaseName: external-dns
values: |
  env:
    - name: "CF_API_TOKEN"
      valueFrom:
        secretKeyRef:
          key:  api-key
          name: cloudflare-api-key-secret
  txtOwnerId: mgmt
  txtPrefix: "mgmt-"
  domainFilters:
    - example.com
  sources:
    - service
    - ingress
    - crd
  extraArgs:
    - "--label-filter=external-dns-exclude notin (true)"
  provider: "cloudflare"
  policy: sync

Anything else we need to know?:

I've tried ensuring it isn't some bug around the --label-filter by removing it and also trying it with the label external-dns-exclude: "false" but again, same result of a noop.

Environment:

• External-DNS version: 1.15.0:
• DNS provider: Cloudflare
• Others:

[juan-vg]

Hey @drew-viles, I discovered the fix:

  extraArgs:
    - ...
    - --managed-record-types=A
    - --managed-record-types=AAAA
    - --managed-record-types=CNAME
    - --managed-record-types=NS

By default the managed types are A, AAAA and CNAME, so any other type must be explicitly defined to be allowed. I believe the problem here are the docs, since for many providers this is not specified. I found the useful info at the PowerDNS docs, and that's not even mentioned for other providers like AWS or Cloudflare.

[drew-viles]

aaah nice spot. thanks for confirming and for raising the PR for the docs clarification.