Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare 5XX responses crash pod #4876

Open
kevinfrommelt opened this issue Nov 14, 2024 · 5 comments
Open

Cloudflare 5XX responses crash pod #4876

kevinfrommelt opened this issue Nov 14, 2024 · 5 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@kevinfrommelt
Copy link

What happened:
Cloudflare temporarily returned 5XXs for zone lookup calls, which caused the pods to crash.

What you expected to happen:
Log an error without crashing and try again later.

How to reproduce it (as minimally and precisely as possible):
Likely can't without mocking the API responses from Cloudflare.

Anything else we need to know?:
Here are some relevant logs
Screenshot 2024-11-14 at 9 32 25 AM

Environment:

  • External-DNS version (use external-dns --version): 0.14.2
  • DNS provider: cloudflare
  • Others:
@kevinfrommelt kevinfrommelt added the kind/bug Categorizes issue or PR as related to a bug. label Nov 14, 2024
@kevinfrommelt
Copy link
Author

It is also crashing on rate limits for zone lookups.

zone fd823e13e494d5430aea9dfd4311a6e1 lookup failed, exceeded available rate limit retries
Failed to do run once: exceeded available rate limit retries

@glaberge
Copy link

Experiencing these crash as well

@ivankatliarchuk
Copy link
Contributor

/help

When not related example solution #4573 for another provider

Ideally this will required a global rate limiter

@k8s-ci-robot
Copy link
Contributor

@ivankatliarchuk:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

When not related example solution #4573 for another provider

Ideally this will required a global rate limiter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 1, 2025
@ivankatliarchuk
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants