Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI provider does not handle multiple A/AAAA records correctly #4940

Open
eshneken opened this issue Dec 10, 2024 · 2 comments
Open

OCI provider does not handle multiple A/AAAA records correctly #4940

eshneken opened this issue Dec 10, 2024 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@eshneken
Copy link

What happened: When attempting to create DNS records of type A or AAAA and providing multiple IPs an error is returned. With one IP this works fine.

What you expected to happen: Expectation is that the provider will process each IP as a separate SDK call to create a DNS record.

How to reproduce it (as minimally and precisely as possible): A request such as the following:

{"domain":"foo.com","operation":"ADD","rdata":"101.65.49.43 101.65.55.218","rtype":"A","ttl":20}

results in the following error:

{
  "code" : "InvalidParameter",
  "message" : "Record (foo.com, A) contained invalid rdata (101.65.49.43 101.65.55.218)"
}

Anything else we need to know?:

Environment:

  • External-DNS version (use external-dns --version): latest version
  • DNS provider: OCI
  • Others:
@eshneken eshneken added the kind/bug Categorizes issue or PR as related to a bug. label Dec 10, 2024
@jrosinsk
Copy link
Contributor

Thanks for reporting this @eshneken .
Rather than call newRecordOperation once with multiple target IP's, we should be calling newRecordOperation separately for each target IP individually in the case of A and AAAA records.
I'll work on a PR for this.

@jrosinsk
Copy link
Contributor

/assign @jrosinsk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants