Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(source): allow ipv4-mapped ipv6 addresses #4943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(source): allow ipv4-mapped ipv6 addresses #4943

wants to merge 1 commit into from
+6 −16

Conversation

buroa
Copy link

@buroa buroa commented Dec 11, 2024 •
edited
Loading

Description

Updates suitableType to allow all valid IPv6 addresses, including IPv4-mapped IPv6 addresses.

https://pkg.go.dev/net/netip#Addr.Is6

Fixes #4942

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @buroa!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @buroa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2024
@buroa
Copy link
Author

buroa commented Dec 11, 2024

Hey @stevehipwell, hope this is an easy one :)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2024
@stevehipwell
Copy link
Contributor

@buroa this isn't really my area of expertise, but with my limited knowledge this looks OK to test ready for a review from one of the maintainers.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2024
@buroa
Copy link
Author

buroa commented Dec 16, 2024

Hi @mloiseleur does this look okay?

@mloiseleur
Copy link
Contributor

Thanks @buroa for this. It looks better.
Would you please add a test with this ipv4-mapped ipv6 that is not passing with current code and works with this new code ?

@buroa
Copy link
Author

buroa commented Dec 21, 2024

Thanks @buroa for this. It looks better. Would you please add a test with this ipv4-mapped ipv6 that is not passing with current code and works with this new code ?

Done!

@mloiseleur
Copy link
Contributor

thanks 👍
/lgtm
/assign @Raffo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2024
@mloiseleur mloiseleur removed their assignment Dec 22, 2024
@mloiseleur
Copy link
Contributor

/retitle fix(source): allow ipv4-mapped ipv6 addresses

@k8s-ci-robot k8s-ci-robot changed the title fix: allow ipv4-mapped ipv6 addresses fix(source): allow ipv4-mapped ipv6 addresses Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@Raffo Raffo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

external-dns disregards valid IPv4-mapped IPv6 addresses
5 participants
@buroa @k8s-ci-robot @stevehipwell @mloiseleur @Raffo