-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group is not optional in LocalObjectReference #3322
Comments
Thanks for opening this, this is a relatively simple change that just needs /good-first-issue |
@youngnick: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @youngnick |
Though it is a simple change, it relaxes the constraints on an api already marked v1. Not sure that is halal with the maintainers? Should this struct be copied for the BackendTLSPolicy and only relaxed there or relaxed everywhere? @youngnick |
This is strange. I didn't have any issue with this in my PR for testing BackendTLSPolicy.
|
I guess there is nothing to fix here. I remember getting error from k8s but I can't reproduce this in k8s 1.31 anymore.
Sorry for the false alert. |
there's still a bug here, the doc string says when |
I've reopened because I agree that this field should be optional. Kind and Name still need to be required though. This is a good-first-issue still, because it's a small, contained change. |
Fixes kubernetes-sigs#3322 Signed-off-by: Tamal Saha <[email protected]>
Hi @youngnick, I hope you’re doing well! Could you please assign this task to me? I’d like to take it if it's still up for grabs :) |
/assign |
Hey @youngnick would you be willing to remove this tag and the |
I am not working on it. I don't understand what is acceptable to the maintainers. If anyone wants to take over, please feel free to do so. |
LocalObjectReference group field is not marked optional. So, it can't be left unspecified or set to empty string.
In BackendTLSPolicy, we try to ref to a Secret and CRD fails validation check as group is ""
Previous conv in Slack: https://kubernetes.slack.com/archives/CR0H13KGA/p1725096986532939
The text was updated successfully, but these errors were encountered: