Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerd 2.0 support #3768

Open
2 tasks
aojea opened this issue Oct 27, 2024 · 3 comments · May be fixed by #3828
Open
2 tasks

Containerd 2.0 support #3768

aojea opened this issue Oct 27, 2024 · 3 comments · May be fixed by #3828
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@aojea
Copy link
Contributor

aojea commented Oct 27, 2024

Containerd is close to release a new major version 2.0 and this will may bring some changes

Per example, I had to test something with containerd 2.0 and the kind load docker-images command fails with

kind load docker-image ghcr.io/aojea/kindnetd:v1.6.0
Image: "ghcr.io/aojea/kindnetd:v1.6.0" with ID "sha256:03579ba24d18613b5f6af6fe639a877d59e899ce88214598ef228e98484b0354" not yet present on node "kind-worker", loading...
Image: "ghcr.io/aojea/kindnetd:v1.6.0" with ID "sha256:03579ba24d18613b5f6af6fe639a877d59e899ce88214598ef228e98484b0354" not yet present on node "kind-worker2", loading...
Image: "ghcr.io/aojea/kindnetd:v1.6.0" with ID "sha256:03579ba24d18613b5f6af6fe639a877d59e899ce88214598ef228e98484b0354" not yet present on node "kind-control-plane", loading...
ERROR: failed to detect containerd snapshotter

Tasks

Preview Give feedback
@aojea aojea added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 27, 2024
@aojea
Copy link
Contributor Author

aojea commented Oct 27, 2024

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Oct 28, 2024

snapshotter, ok := parsed.GetPath([]string{"plugins", "io.containerd.grpc.v1.cri", "containerd", "snapshotter"}).(string)

For containerd config version 3 (introduced in containerd v2.0), this function should check plugins.'io.containerd.cri.v1.images'.snapshotter.

See https://github.com/containerd/containerd/blob/v2.0.0-rc.6/docs/cri/config.md#snapshotter

@BenTheElder
Copy link
Member

We should definitely not rush containerd 2.0, consider also that we desire to support older kubernetes releases for a while

We have preemptively been preparing in some cases like #2875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@BenTheElder @aojea @AkihiroSuda and others