Merge pull request #5083 from camilamacedo86/fix-helm-chart-certmanager

k8s-ci-robot · web-flow · commit 1aa21686ec7e · 2025-09-07T05:03:30.000-07:00
⚠️ (helm/v1-alpha): Migrate from installCRDs=true to crds.enabled=true in GitHub action `test-chart.yml`
diff --git a/.github/workflows/test-helm-book.yml b/.github/workflows/test-helm-book.yml
@@ -79,7 +79,7 @@ jobs:
         run: |
           helm repo add jetstack https://charts.jetstack.io
           helm repo update
-          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 
       - name: Wait for cert-manager to be ready
         run: |
diff --git a/.github/workflows/test-helm-samples.yml b/.github/workflows/test-helm-samples.yml
@@ -65,7 +65,7 @@ jobs:
         run: |
           helm repo add jetstack https://charts.jetstack.io
           helm repo update
-          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 
       - name: Wait for cert-manager to be ready
         run: |
diff --git a/docs/book/src/cronjob-tutorial/testdata/project/.github/workflows/test-chart.yml b/docs/book/src/cronjob-tutorial/testdata/project/.github/workflows/test-chart.yml
@@ -51,7 +51,7 @@ jobs:
         run: |
           helm repo add jetstack https://charts.jetstack.io
           helm repo update
-          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 
       - name: Wait for cert-manager to be ready
         run: |
diff --git a/docs/book/src/getting-started/testdata/project/.github/workflows/test-chart.yml b/docs/book/src/getting-started/testdata/project/.github/workflows/test-chart.yml
@@ -51,7 +51,7 @@ jobs:
 #        run: |
 #          helm repo add jetstack https://charts.jetstack.io
 #          helm repo update
-#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 #
 #      - name: Wait for cert-manager to be ready
 #        run: |
diff --git a/docs/book/src/multiversion-tutorial/testdata/project/.github/workflows/test-chart.yml b/docs/book/src/multiversion-tutorial/testdata/project/.github/workflows/test-chart.yml
@@ -51,7 +51,7 @@ jobs:
         run: |
           helm repo add jetstack https://charts.jetstack.io
           helm repo update
-          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 
       - name: Wait for cert-manager to be ready
         run: |
diff --git a/pkg/plugins/common/kustomize/v2/scaffolds/webhook.go b/pkg/plugins/common/kustomize/v2/scaffolds/webhook.go
@@ -142,7 +142,7 @@ func (s *webhookScaffolder) Scaffold() error {
 #        run: |
 #          helm repo add jetstack https://charts.jetstack.io
 #          helm repo update
-#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 #
 #      - name: Wait for cert-manager to be ready
 #        run: |
diff --git a/pkg/plugins/optional/helm/v1alpha/edit.go b/pkg/plugins/optional/helm/v1alpha/edit.go
@@ -110,7 +110,7 @@ func (p *editSubcommand) PostScaffold() error {
 #        run: |
 #          helm repo add jetstack https://charts.jetstack.io
 #          helm repo update
-#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 #
 #      - name: Wait for cert-manager to be ready
 #        run: |
diff --git a/pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/github/test_chart.go b/pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/github/test_chart.go
@@ -97,7 +97,7 @@ jobs:
 #        run: |
 #          helm repo add jetstack https://charts.jetstack.io
 #          helm repo update
-#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+#          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 #
 #      - name: Wait for cert-manager to be ready
 #        run: |
diff --git a/testdata/project-v4-with-plugins/.github/workflows/test-chart.yml b/testdata/project-v4-with-plugins/.github/workflows/test-chart.yml
@@ -51,7 +51,7 @@ jobs:
         run: |
           helm repo add jetstack https://charts.jetstack.io
           helm repo update
-          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true
+          helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true
 
       - name: Wait for cert-manager to be ready
         run: |

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ jobs:`
`51`	`51`	`# run: \|`
`52`	`52`	`# helm repo add jetstack https://charts.jetstack.io`
`53`	`53`	`# helm repo update`
`54`		`-# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true`
	`54`	`+# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true`
`55`	`55`	`#`
`56`	`56`	`# - name: Wait for cert-manager to be ready`
`57`	`57`	`# run: \|`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ func (s *webhookScaffolder) Scaffold() error {`
`142`	`142`	`# run: \|`
`143`	`143`	`# helm repo add jetstack https://charts.jetstack.io`
`144`	`144`	`# helm repo update`
`145`		`-# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true`
	`145`	`+# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true`
`146`	`146`	`#`
`147`	`147`	`# - name: Wait for cert-manager to be ready`
`148`	`148`	`# run: \|`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ func (p *editSubcommand) PostScaffold() error {`
`110`	`110`	`# run: \|`
`111`	`111`	`# helm repo add jetstack https://charts.jetstack.io`
`112`	`112`	`# helm repo update`
`113`		`-# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true`
	`113`	`+# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true`
`114`	`114`	`#`
`115`	`115`	`# - name: Wait for cert-manager to be ready`
`116`	`116`	`# run: \|`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ jobs:`
`97`	`97`	`# run: \|`
`98`	`98`	`# helm repo add jetstack https://charts.jetstack.io`
`99`	`99`	`# helm repo update`
`100`		`-# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true`
	`100`	`+# helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set crds.enabled=true`
`101`	`101`	`#`
`102`	`102`	`# - name: Wait for cert-manager to be ready`
`103`	`103`	`# run: \|`