Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golden script for Windows #1126

Closed
Adirio opened this issue Oct 25, 2019 · 6 comments
Closed

Golden script for Windows #1126

Adirio opened this issue Oct 25, 2019 · 6 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Adirio
Copy link
Contributor

Adirio commented Oct 25, 2019

./generate_golden.sh does not work under Windows.

I tried to do some modifications to make the script work in windows, like using bash ... instead of ./... notation and converting all paths to Windows style (including $PWD and $(pwd) outputs). But I stopped when I saw it was downloading some tools that are only for darwin and linux.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2019
@droot
Copy link
Contributor

droot commented Oct 30, 2019

@Adirio yes you are right. Kubebuilder ships k8s binaries such as api-server, etcd and kubectl which are used in the tests. So we will need those for windows to fully support it on Windows.

@droot droot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 30, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 27, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Mar 4, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 4, 2020
@Adirio Adirio mentioned this issue Mar 4, 2020
@camilamacedo86
Copy link
Member

camilamacedo86 commented May 8, 2020

HI @Adirio,

I have not a Windows system. However, shows that all problems regards the win SO would be solved if we add as pre-requirement use the https://www.cygwin.com/ to work with. Could you please help us by verifying it?

c/c @joelanford @estroz

@camilamacedo86 camilamacedo86 added this to the next milestone Nov 3, 2020
@camilamacedo86 camilamacedo86 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 1, 2020
@camilamacedo86 camilamacedo86 removed this from the next milestone Dec 1, 2020
@camilamacedo86
Copy link
Member

Closed in favor of : #2940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants