Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Kubebuilder Makefile #1407

Closed
Adirio opened this issue Mar 4, 2020 · 10 comments
Closed

[Windows] Kubebuilder Makefile #1407

Adirio opened this issue Mar 4, 2020 · 10 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Adirio
Copy link
Contributor

Adirio commented Mar 4, 2020

Description

Kubebuilders Makefile is not compatible with windows as it uses unix-style paths, among other things. Update the Makefile to provide Windows compatibility without loosing Linux and Mac compatibility.

Please, comment here before taking this task to coordinate development efforts.

Note: this task is tracked in #1405
@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 4, 2020
@Adirio Adirio mentioned this issue Mar 4, 2020
Closed
4 tasks
@Adirio
Copy link
Contributor Author

Adirio commented Mar 4, 2020

#1351 may help with this

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 2, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Adirio
Copy link
Contributor Author

Adirio commented Oct 27, 2020

/reopen
/lifecycle frozen

@k8s-ci-robot
Copy link
Contributor

@Adirio: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Oct 27, 2020
@camilamacedo86 camilamacedo86 modified the milestone: next Nov 3, 2020
@camilamacedo86 camilamacedo86 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Dec 1, 2020
@camilamacedo86
Copy link
Member

camilamacedo86 commented Dec 1, 2020 •
edited
Loading

In the bug triage meeting, we spoke about to support windows officially and we all agreed that it would be nice. However, we would need help from the community to achieve this goal. More info: #1405 (comment)

@MarcosNBJ
Copy link

MarcosNBJ commented Sep 23, 2021 •
edited
Loading

In the Makefile there are some steps that rely on other scripts, such as "/test/integration.sh" or "/test/e2e/local.sh" for example. Those would also need to be modified in order to make it Windows compatible, right? Or are they already compatible?

@camilamacedo86 camilamacedo86 mentioned this issue Sep 13, 2022
Open
@camilamacedo86
Copy link
Member

Closed in favor of : #2940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Adirio @camilamacedo86 @MarcosNBJ @k8s-ci-robot @fejta-bot