feat: support multiple document yaml files #143
Draft
+128
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #123
Special notes for your reviewer:
(Option 2) An alternative would be to ensure that the "metadata" of the status object includes the right detail:example
I think the second option might be nicer, I'll follow up with that shortly for comparison.The above appear to be existing fields in the status we could populate.On closer look, name is already in use, so that won't work as first thought, nor do I think it would work with generated names well.
{ "/tmp/foo.yaml:$(documentNumber}": [
or
{ "/tmp/foo.yaml:$(gvk}:$(name}": [
Potentially, we could make it so that the key is returned in the prior format if there is only 1 document in a file?
map[string][]metav1.Status{}
->map[string][]NewType{}
As this doesn't break the general structure of the output and simply extends it, I'm inclined to try this out:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: